Add an instruction for using Docker buildx when building containers.#37706
Add an instruction for using Docker buildx when building containers.#37706tvalentyn wants to merge 4 commits intoapache:masterfrom
Conversation
Summary of ChangesHello @tvalentyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation for building Docker containers using Gradle. It updates the Python SDK container build target to a newer version and provides crucial guidance for users encountering common Docker build warnings, directing them to use Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
r: @liferoad |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
liferoad
left a comment
liferoad
left a comment
There was a problem hiding this comment.
LGTM — docs updates are clear and useful.\n\nThanks for adding:\n- in custom repository examples\n- guidance for the no-output Docker warning\n- explicit usage note\n\nThese changes should reduce common container build/push confusion for contributors.
liferoad
left a comment
liferoad
left a comment
There was a problem hiding this comment.
LGTM — docs updates are clear and useful.
Thanks for adding:
-Ppush-containersin custom repository examples-PuseDockerBuildxguidance for the no-output Docker warning- explicit
--sdk_container_imageusage note
These changes should reduce common container build/push confusion for contributors.
2 participants
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.